Thanks! I’ll go ask Tiff about getting reddthat updated later.
BTW, is there a community for discussion of mlmym itself somewhere on lemmy? I can’t participate on GitHub, but those aren’t the only issues I’ve found. (e.g. there’s also ?format=jpg&thumbnail=96 on non-pictrs links and a text handling issue with angle brackets…)
Note that it’s making a request to kbin.social with ?format=jpg&thumbnail=96 parameters in the CSS – which results in the full image being loaded since kbin doesn’t run pictrs.
The versions in use on reddthat (according to the settings page) are:
Thanks! I’ll go ask Tiff about getting reddthat updated later.
BTW, is there a community for discussion of mlmym itself somewhere on lemmy? I can’t participate on GitHub, but those aren’t the only issues I’ve found. (e.g. there’s also
?format=jpg&thumbnail=96
on non-pictrs links and a text handling issue with angle brackets…)no lemmy community for mlmym yet, that’s good idea.
do you have an example of that thumbnail issue?
I ran into an example of the thumbnail issue again today – this time on a post from kbin: https://old.reddthat.com/post/19193476
The thumbnail looks like this in the HTML:
Note that it’s making a request to kbin.social with
?format=jpg&thumbnail=96
parameters in the CSS – which results in the full image being loaded since kbin doesn’t run pictrs.The versions in use on reddthat (according to the settings page) are:
lemmy: 0.19.4-beta.7
mlmym: 0.0.44
This kinda looks like an issue between lemmy and kbin. The issue is present on the lemmy ui as well. The
?format=jpg&thumbnail=96
parameter being there doesn’t have an effect here. The issue is the thumbnail_url is reported wrong. You can see that here. The thumbnail_url should be: https://kbin.social/media/cache/resolve/entry_thumb/60/a4/60a45b8ff88b1b2e3a0f77b701feb323c5bbfb7ceeb75154ea7df5d6eea15ef8.jpg We could try and use some regex to lookout for kbin images and rewrite the thumbnail_url, but it should probably just be fixed upstream.Found this github issue which might be related: https://github.com/LemmyNet/lemmy/issues/3775